feat: InMemoryCatalog::CreateTable & StageCreateTable api #416
+667
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WZhuo
force-pushed
the
create_table
branch
2 times, most recently
from
b83be34 to
805973f
Compare
WZhuo
force-pushed
the
create_table
branch
3 times, most recently
from
a399aee to
9190a30
Compare
wgtmac
reviewed
Dec 25, 2025
src/iceberg/table_metadata.h
Outdated
| int64_t next_row_id; | ||
|
|
||
| static Result<std::unique_ptr<TableMetadata>> Make( | ||
| const iceberg::Schema& schema, const iceberg::PartitionSpec& spec, |
Member
There was a problem hiding this comment.
Do you think we should rename functions below to GetSchema, GetSnapshot, etc. so we don't need to write iceberg:: prefix here and elsewhere?
Contributor
Author
There was a problem hiding this comment.
- Rename the function name like
GetSchema. - use
classkeyword replace of the namespace specified, likeconst class Schema& schema, const class PartitionSpec& spec.
There's no need to write the namespaceicebergprefix other than TableMetadata's class scope. So I don't think rename function is well, we'll writeGetSchemaeverywhere. I prefer solution 2.
src/iceberg/table_metadata.cc
Outdated
| } | ||
|
|
||
| // Reassign all column ids to ensure consistency | ||
| std::atomic<int32_t> last_column_id = 0; |
Member
There was a problem hiding this comment.
Why do we need to use atomic here?
Contributor
Author
There was a problem hiding this comment.
Yeah, It's convert from java, I think it's not really needed, fix it.
src/iceberg/table_metadata.cc
Outdated
| constexpr std::string_view kMetadataFolderName = "metadata"; | ||
|
|
||
| // TableMetadata private static methods | ||
| Result<std::shared_ptr<PartitionSpec>> FreshPartitionSpec( |
Member
There was a problem hiding this comment.
I think FreshPartitionSpec and FreshSortOrder should also be called in the SetDefaultPartitionSpec and SetDefaultSortOrder, respectively.
Contributor
Author
There was a problem hiding this comment.
Unlike Java impl, I think no need to fresh field id in the TableMetadataBuilder::AddXXX.
WZhuo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.